Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect response result for sortcontact command #156

Merged
merged 1 commit into from
Nov 6, 2021

Conversation

yatbun
Copy link

@yatbun yatbun commented Nov 6, 2021

Also standardised sortpolicy command result.

Fix #155

@yatbun yatbun added the bug Something isn't working label Nov 6, 2021
@yatbun yatbun added this to the v1.4 milestone Nov 6, 2021
@yatbun yatbun requested a review from meerian November 6, 2021 07:56
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2021

Codecov Report

Merging #156 (fba9e1b) into master (8423a8d) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #156   +/-   ##
=========================================
  Coverage     49.64%   49.64%           
  Complexity      503      503           
=========================================
  Files           107      107           
  Lines          2270     2270           
  Branches        280      280           
=========================================
  Hits           1127     1127           
  Misses         1083     1083           
  Partials         60       60           
Impacted Files Coverage Δ
...asa/logic/commands/contact/SortContactCommand.java 0.00% <0.00%> (ø)
...siasa/logic/commands/policy/SortPolicyCommand.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8423a8d...fba9e1b. Read the comment docs.

@meerian meerian changed the title Fix incorrect repsonse result for sortcontact command Fix incorrect response result for sortcontact command Nov 6, 2021
Copy link

@meerian meerian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meerian meerian merged commit 78bc60a into master Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected behavior for sortcontact
3 participants