-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sherwin refactor sort policy comparators, commission for download and command messages #150
Sherwin refactor sort policy comparators, commission for download and command messages #150
Conversation
sherrpass
commented
Nov 5, 2021
•
edited
Loading
edited
- Enhanced sortpolicy comparators for to calculate total payment and total commission.
- Refactored commission calculation for download commnad
- Improve command messages for several commands
…tps://github.com/AY2122S1-CS2103-F10-4/tp into zhuoyang_code-quality-improvements-warning-stats
…into sherwin-refactor-command-messages-sort-commission
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To standardise output messages. I will look at how to show empty lists better.
src/main/java/seedu/siasa/logic/commands/contact/SortContactCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/siasa/logic/commands/policy/ListPolicyCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/siasa/logic/commands/policy/ShowExpiringPolicyCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/siasa/logic/commands/contact/SortContactCommand.java
Show resolved
Hide resolved
- Made the Happy Path more prominent - Added empty list check to all relevant commands
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
============================================
- Coverage 50.55% 49.64% -0.91%
+ Complexity 506 503 -3
============================================
Files 106 107 +1
Lines 2243 2270 +27
Branches 273 280 +7
============================================
- Hits 1134 1127 -7
- Misses 1050 1083 +33
- Partials 59 60 +1
Continue to review full report at Codecov.
|
…ttps://github.com/AY2122S1-CS2103-F10-4/tp into sherwin-refactor-command-messages-sort-commission
LGTM for your changes yatbun, but I think we definitely need to boost our test cases in a future PR. |
LGTM! |