Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sherwin refactor sort policy comparators, commission for download and command messages #150

Merged
merged 16 commits into from
Nov 6, 2021

Conversation

sherrpass
Copy link

@sherrpass sherrpass commented Nov 5, 2021

  • Enhanced sortpolicy comparators for to calculate total payment and total commission.
  • Refactored commission calculation for download commnad
  • Improve command messages for several commands

@sherrpass sherrpass requested a review from a team November 5, 2021 16:54
Copy link

@yatbun yatbun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To standardise output messages. I will look at how to show empty lists better.

@yatbun yatbun added this to the v1.4 milestone Nov 5, 2021
- Made the Happy Path more prominent
- Added empty list check to all relevant commands
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2021

Codecov Report

Merging #150 (14f65c0) into master (8c4035d) will decrease coverage by 0.90%.
The diff coverage is 11.76%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #150      +/-   ##
============================================
- Coverage     50.55%   49.64%   -0.91%     
+ Complexity      506      503       -3     
============================================
  Files           106      107       +1     
  Lines          2243     2270      +27     
  Branches        273      280       +7     
============================================
- Hits           1134     1127       -7     
- Misses         1050     1083      +33     
- Partials         59       60       +1     
Impacted Files Coverage Δ
src/main/java/seedu/siasa/MainApp.java 0.00% <0.00%> (ø)
...c/main/java/seedu/siasa/commons/core/Messages.java 0.00% <ø> (ø)
...in/java/seedu/siasa/commons/util/CurrencyUtil.java 0.00% <0.00%> (ø)
.../java/seedu/siasa/logic/commands/ClearCommand.java 14.28% <0.00%> (-85.72%) ⬇️
...va/seedu/siasa/logic/commands/DownloadCommand.java 0.00% <0.00%> (ø)
...n/java/seedu/siasa/logic/commands/ExitCommand.java 100.00% <ø> (ø)
...iasa/logic/commands/contact/AddContactCommand.java 66.66% <ø> (ø)
...a/logic/commands/contact/DeleteContactCommand.java 100.00% <ø> (ø)
...asa/logic/commands/contact/EditContactCommand.java 97.01% <ø> (ø)
...gic/commands/contact/ListContactPolicyCommand.java 0.00% <0.00%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4035d...14f65c0. Read the comment docs.

@yatbun yatbun requested review from yatbun and a team and removed request for yatbun November 5, 2021 20:09
@sherrpass
Copy link
Author

LGTM for your changes yatbun, but I think we definitely need to boost our test cases in a future PR.

@sherrpass sherrpass linked an issue Nov 6, 2021 that may be closed by this pull request
@zhuoyang125
Copy link

LGTM!

@zhuoyang125 zhuoyang125 merged commit 8423a8d into master Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants