Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exceptions due to FilteredList #149

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Fix exceptions due to FilteredList #149

merged 1 commit into from
Nov 5, 2021

Conversation

yatbun
Copy link

@yatbun yatbun commented Nov 5, 2021

No description provided.

@yatbun yatbun added the bug Something isn't working label Nov 5, 2021
@yatbun yatbun added this to the v1.4 milestone Nov 5, 2021
@yatbun yatbun requested a review from sherrpass November 5, 2021 12:21
@yatbun yatbun self-assigned this Nov 5, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2021

Codecov Report

Merging #149 (19ac7b2) into master (b3d7f58) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #149      +/-   ##
============================================
+ Coverage     50.92%   51.01%   +0.09%     
  Complexity      506      506              
============================================
  Files           106      106              
  Lines          2227     2223       -4     
  Branches        266      266              
============================================
  Hits           1134     1134              
+ Misses         1034     1030       -4     
  Partials         59       59              
Impacted Files Coverage Δ
src/main/java/seedu/siasa/model/ModelManager.java 77.10% <ø> (+3.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3d7f58...19ac7b2. Read the comment docs.

@sherrpass
Copy link

LGTM!

@sherrpass sherrpass merged commit c365002 into master Nov 5, 2021
@yatbun yatbun deleted the yatbun_sort-fix branch November 5, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants