Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sherwin make expiry date optional #144

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Conversation

sherrpass
Copy link

No description provided.

@sherrpass sherrpass requested a review from zhuoyang125 November 3, 2021 17:05
@sherrpass sherrpass linked an issue Nov 3, 2021 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2021

Codecov Report

Merging #144 (67d875f) into master (86c8d99) will decrease coverage by 0.25%.
The diff coverage is 28.12%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #144      +/-   ##
============================================
- Coverage     51.49%   51.24%   -0.26%     
  Complexity      506      506              
============================================
  Files           105      105              
  Lines          2206     2213       +7     
  Branches        262      264       +2     
============================================
- Hits           1136     1134       -2     
- Misses         1011     1020       +9     
  Partials         59       59              
Impacted Files Coverage Δ
.../siasa/logic/commands/policy/AddPolicyCommand.java 0.00% <0.00%> (ø)
...siasa/logic/commands/policy/EditPolicyCommand.java 0.00% <0.00%> (ø)
...gic/commands/policy/ShowExpiringPolicyCommand.java 0.00% <0.00%> (ø)
...sa/logic/parser/policy/AddPolicyCommandParser.java 0.00% <0.00%> (ø)
...ava/seedu/siasa/model/policy/PolicyComparator.java 42.85% <0.00%> (-4.52%) ⬇️
src/main/java/seedu/siasa/ui/PolicyCard.java 0.00% <0.00%> (ø)
src/main/java/seedu/siasa/model/policy/Policy.java 60.78% <28.57%> (-2.49%) ⬇️
...in/java/seedu/siasa/storage/JsonAdaptedPolicy.java 90.56% <77.77%> (-3.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86c8d99...67d875f. Read the comment docs.

Copy link

@zhuoyang125 zhuoyang125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhuoyang125 zhuoyang125 merged commit 24644c6 into master Nov 4, 2021
@yatbun yatbun mentioned this pull request Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D] Incorrect example notation for addPolicy command in UG
3 participants