Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zhuoyang fix warning #143

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Zhuoyang fix warning #143

merged 2 commits into from
Nov 4, 2021

Conversation

zhuoyang125
Copy link

@zhuoyang125 zhuoyang125 commented Nov 3, 2021

Fixes #102.
Closing the window will cancel the command.

@zhuoyang125 zhuoyang125 self-assigned this Nov 3, 2021
@zhuoyang125 zhuoyang125 requested a review from a team November 3, 2021 16:58
@zhuoyang125 zhuoyang125 added the bug Something isn't working label Nov 3, 2021
@zhuoyang125 zhuoyang125 added this to the v1.4 milestone Nov 3, 2021
Copy link

@yatbun yatbun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice quick fix

@yatbun yatbun merged commit 254c89c into master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D] The policy is added even when the cross button is selected on the popup
2 participants