Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix t/ prefix not working for editpolicy command #140

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

yatbun
Copy link

@yatbun yatbun commented Nov 3, 2021

Fix #108

@yatbun yatbun added the bug Something isn't working label Nov 3, 2021
@yatbun yatbun requested a review from a team November 3, 2021 14:19
@yatbun yatbun self-assigned this Nov 3, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #140 (3379fed) into master (86c8d99) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #140      +/-   ##
============================================
- Coverage     51.49%   51.35%   -0.14%     
  Complexity      506      506              
============================================
  Files           105      105              
  Lines          2206     2212       +6     
  Branches        262      264       +2     
============================================
  Hits           1136     1136              
- Misses         1011     1017       +6     
  Partials         59       59              
Impacted Files Coverage Δ
...logic/parser/contact/EditContactCommandParser.java 92.30% <ø> (ø)
...a/logic/parser/policy/EditPolicyCommandParser.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86c8d99...3379fed. Read the comment docs.

@yatbun yatbun added this to the v1.4 milestone Nov 4, 2021
Copy link

@meerian meerian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@meerian meerian merged commit 4532b24 into master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D] editpolicy functionality bug prefix t/ not working
3 participants