Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bookkeeping overflow #202

Conversation

bryanwee023
Copy link

Fixes #199.

Bookkeeping figures overflow due to the lack of checks.

Let's impose a reasonable limit ($999, 999, 999) onto Bookkeeping figures. Revenue or costs above the limit will not be considered. This allows us to perform overflow checks.

@bryanwee023 bryanwee023 force-pushed the fix-bookkeeping-overflow branch from 7560c4b to 4deaced Compare November 6, 2021 20:57
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2021

Codecov Report

Merging #202 (08de2f0) into master (8212590) will increase coverage by 0.07%.
The diff coverage is 95.83%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #202      +/-   ##
============================================
+ Coverage     77.32%   77.39%   +0.07%     
- Complexity      808      809       +1     
============================================
  Files            99       99              
  Lines          2187     2181       -6     
  Branches        311      310       -1     
============================================
- Hits           1691     1688       -3     
  Misses          382      382              
+ Partials        114      111       -3     
Impacted Files Coverage Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø)
...main/java/seedu/address/model/TransactionList.java 100.00% <ø> (ø)
.../java/seedu/address/model/util/SampleDataUtil.java 12.50% <0.00%> (ø)
.../java/seedu/address/logic/commands/AddCommand.java 83.87% <100.00%> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 89.58% <100.00%> (ø)
src/main/java/seedu/address/model/BookKeeping.java 96.77% <100.00%> (+11.92%) ⬆️
...rc/main/java/seedu/address/model/ModelManager.java 91.36% <100.00%> (-0.13%) ⬇️
...u/address/storage/JsonSerializableBookKeeping.java 100.00% <100.00%> (ø)
src/main/java/seedu/address/model/UserPrefs.java 94.87% <0.00%> (-2.57%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8212590...08de2f0. Read the comment docs.

@GraceWang2322 GraceWang2322 merged commit abc9532 into AY2122S1-CS2103-F10-2:master Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List txns calculate profit overflow
3 participants