Enhance arg multimap #192
Merged
Enhance arg multimap #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
============================================
+ Coverage 71.44% 71.50% +0.06%
+ Complexity 739 736 -3
============================================
Files 99 99
Lines 2150 2141 -9
Branches 298 296 -2
============================================
- Hits 1536 1531 -5
+ Misses 497 496 -1
+ Partials 117 114 -3
Continue to review full report at Codecov.
|
bernarduskrishna
approved these changes
Nov 6, 2021
Comment on lines
+55
to
+75
| /* Equivalence Partitions: | ||
| Expected Prefixes: | ||
| - No prefixes | ||
| - Single character prefixes | ||
| - Multiple character prefixes | ||
| - Prefixes not in arg string | ||
|
|
||
| Preamble: | ||
| - Empty string | ||
| - Single word | ||
| - Multiple word | ||
|
|
||
| Parameters: | ||
| - Empty parameter | ||
| - Single word | ||
| - Multiple word | ||
| - Single word with trailing / leading spaces | ||
| - Multiple word with trailing / leading spaces | ||
|
|
||
| The following test cases attempts to cover all partitions in an efficient manner. | ||
| */ |
There was a problem hiding this comment.
Yup LGTM. Nice that you put the equivalence partitions as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #191 .
ArgumentTokenizershould attempt to detect all possible prefixes. If it detects a prefix that is not in its list of expected prefixes, it will throw an appropriateParseException.Misc Edits:
AddToOrderCommandParserTesttoParserUtilTest, where it is more appropriate.