-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp Find #86
Revamp Find #86
Conversation
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
============================================
+ Coverage 73.69% 74.31% +0.62%
- Complexity 506 540 +34
============================================
Files 88 92 +4
Lines 1551 1616 +65
Branches 172 179 +7
============================================
+ Hits 1143 1201 +58
- Misses 351 354 +3
- Partials 57 61 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for minor changes!
src/test/java/seedu/address/logic/commands/FindOrCommandTest.java
Outdated
Show resolved
Hide resolved
src/test/java/seedu/address/logic/parser/AddressBookParserTest.java
Outdated
Show resolved
Hide resolved
src/test/java/seedu/address/logic/parser/AddressBookParserTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for one minor naming thing :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes, otherwise LGTM
src/main/java/seedu/address/logic/parser/AddressBookParser.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #83