Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp Find #86

Merged
merged 7 commits into from
Oct 21, 2021
Merged

Conversation

leezhixuan
Copy link

Resolves #83

@leezhixuan leezhixuan added this to the v1.3 milestone Oct 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2021

Codecov Report

Merging #86 (2f72353) into master (7e817fa) will increase coverage by 0.62%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #86      +/-   ##
============================================
+ Coverage     73.69%   74.31%   +0.62%     
- Complexity      506      540      +34     
============================================
  Files            88       92       +4     
  Lines          1551     1616      +65     
  Branches        172      179       +7     
============================================
+ Hits           1143     1201      +58     
- Misses          351      354       +3     
- Partials         57       61       +4     
Impacted Files Coverage Δ
...in/java/seedu/address/ui/BirthdayReminderCard.java 0.00% <0.00%> (ø)
.../seedu/address/logic/parser/FindCommandParser.java 87.50% <81.81%> (-12.50%) ⬇️
...java/seedu/address/model/person/FindPredicate.java 84.61% <84.61%> (ø)
...eedu/address/logic/parser/FindOrCommandParser.java 87.50% <87.50%> (ø)
...va/seedu/address/model/person/FindOrPredicate.java 88.23% <88.23%> (ø)
...java/seedu/address/logic/commands/FindCommand.java 100.00% <100.00%> (ø)
...va/seedu/address/logic/commands/FindOrCommand.java 100.00% <100.00%> (ø)
.../seedu/address/logic/parser/AddressBookParser.java 100.00% <100.00%> (ø)
...c/main/java/seedu/address/model/person/Person.java 94.00% <0.00%> (+2.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e817fa...2f72353. Read the comment docs.

Copy link

@yucheng11122017 yucheng11122017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for minor changes!

Copy link

@yucheng11122017 yucheng11122017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for one minor naming thing :)

Copy link

@Justinhoejj Justinhoejj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes, otherwise LGTM

Copy link

@Justinhoejj Justinhoejj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leezhixuan leezhixuan merged commit 127cf7b into AY2122S1-CS2103-F09-4:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp Find Command
4 participants