-
Notifications
You must be signed in to change notification settings - Fork 27.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the correct python version on linux #15799
Conversation
Are there systems where python3 exists and python3.10 doesn't? If there are and webui works on them, this change will make webui stop working. |
Just edit |
Users who has only one Python version other than 3.10, will have python3, but not python3.10 available. For example:
Also, if you merge this PR, it would make this check completely useless. |
for those users, they can install python3.10 seperately, for example, |
You are missing the point. We were talking about users with working installations who has some other python version (not 3.10). I know that some people use 3.11 on Linux and they do not have 3.10 installed. This PR would break everything for them and they will have to do what you are suggesting. |
Breaking out of spec setups is unfortunate, but the project clearly expects you to run it with python3.10 and merging this change would be helpful in making sure its not trying to run on an unsupported version of python, your everyday user should not need to tinker with files to tell it to pick the python version its expecting. |
Since I am not a part of the dev team, I can only give my opinion, but devs will decide whether they will accept this PR or not. I agree that 3.10 is the recommended version, and everyone should use that version if possible, but as you can see in I think that we need a better approach that will try to use 3.10 if possible, but if not, fall back to any other version. If your solution worked that way, I would upvote it immediately. EDIT: |
Merged #16092 in. |
Description
Checklist: