Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add duplicate check to v2 #31

Merged
merged 1 commit into from
Jul 19, 2024
Merged

add duplicate check to v2 #31

merged 1 commit into from
Jul 19, 2024

Conversation

chdwlch
Copy link
Collaborator

@chdwlch chdwlch commented Jul 18, 2024

Adds duplicate check. Uses continues to try again for random name generation.
Also did a fresh yarn install and i think it removed some old stuff

curl -X POST http://localhost:3000/v2/record -H "Content-Type: application/json" -d  '{"domain": "twelve.cash","lno": "lno1","userName": "furious.kite1"}'
{"message":"Bip353 Address Created","bip353":"[email protected]"}

curl -X POST http://localhost:3000/v2/record -H "Content-Type: application/json" -d  '{"domain": "twelve.cash","lno": "lno1","userName": "furious.kite1"}'
{"error":{"message":"Failed to update DNS record","errors":[{"message":"Name is already taken."}]}}

curl -X POST http://localhost:3000/v2/record -H "Content-Type: application/json" -d  '{"domain": "twelve.cash","lno": "lno12","userName": "furious.kite1"}'
{"error":{"message":"Failed to update DNS record","errors":[{"message":"Name is already taken."}]}}

Copy link

netlify bot commented Jul 18, 2024

Deploy Preview for twelvecash ready!

Name Link
🔨 Latest commit 7287ec8
🔍 Latest deploy log https://app.netlify.com/sites/twelvecash/deploys/66996b20fe44060008789dda
😎 Deploy Preview https://deploy-preview-31--twelvecash.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@sbddesign sbddesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbddesign sbddesign merged commit 13df0b1 into main Jul 19, 2024
4 checks passed
@sbddesign sbddesign deleted the v2-dup-check branch July 19, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants