IOTIDE-2201 Improve parsing of log output, and fix e-mail address #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ' "added": {json(file_adds)},\\n' + | ||
| ' "modified": {json(file_mods)},\\n' + | ||
| ' "deleted": {json(file_dels)},\\n' + | ||
| ' "desc": {json(desc)}\n}'; |
There was a problem hiding this comment.
A question about this format. I've seen that @mcgordonite wrote that he created a different template here. this looks slightly different. Is it by design?
There was a problem hiding this comment.
I think either are fine: this version has the advantage of being trivial to parse with JSON.parse, but the one in your link didn't require as much escaping in the template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes IOTIDE-2201.
The issue was that the author could contain certain characters that broke json parsing. These characters were not previously escaped. This fix makes use of the Mercurial json function to output text in json format correctly. The hack for the description has now been removed, so the description too is parsed as a part of the json.
I also took the opportunity to fix up the name and email of the author. Whereas Git returns these separately, Mercurial returns them as a single string "name ". This had been returned as the name, with the e-mail being blank. This gave a minor inconsistency between Git and Hg. It also meant the correct avatars were not being used in Hg.