Fix --notestendpt handling

[sukidog]

The test logic was requiring a target executable even when --notestendpt was specified. The target binary is used only by the endpoint testing.

[c1728p9]

@mbed-bot: TEST

[c1728p9]

It might be better to raise and exception here or add a 'vaild' field rather than calling exit. That way the script using this is able to recover from an error rather than exiting

[sukidog]

I thought about that but then noticed there are a number of exit(-1) calls in run_test.py. I was trying to be consistent. Are you saying to throw an exception so the calling function can continue if it wishes to?

[c1728p9]

By script I meant run_test.py. Currently everything which uses exit() resides in run_test.py and isn't meant to be used outside that script. This is more of a nitpick so don't feel like it needs to change. If the need arises in the future to make this case recoverable then it can be changed later.

[sukidog]

Sounds good. I will leave it as is. Doesn't seem like a recoverable error condition. Like you said, we can change that as needed

John

On Apr 14, 2016, at 3:34 PM, Russ Butler [email protected] wrote:

In test/daplink_firmware.py:

     project_dir_list = os.listdir(tool_dir)

•    if not project_dir_list:
  

•        print (errmsg)
  

•        exit(-1) 
  

  By script I meant run_test.py. Currently everything which uses exit() resides in run_test.py and isn't meant to be used outside that script. This is more of a nitpick so don't feel like it needs to change. If the need arises in the future to make this case recoverable then it can be changed later.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

[c1728p9]

@mbed-bot: TEST

[c1728p9]

Thanks for the improvements!