Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught exception when git not in PATH on Windows #84

Merged
merged 2 commits into from
Mar 26, 2016

Conversation

sukidog
Copy link
Contributor

@sukidog sukidog commented Mar 25, 2016

WindowsError, not CalledProcessError, is thrown on Windows when subprocess.Popen() fails due to executable not found. The scripts fails to display a simple, helpful message; user gets a stack trace.

Also various improvements to messages

@c1728p9
Copy link
Contributor

c1728p9 commented Mar 25, 2016

@mbed-bot: TEST

@c1728p9
Copy link
Contributor

c1728p9 commented Mar 26, 2016

@sukidog this patch looks good. Did you want it merged, or were you planning on adding more commits to it?

@sukidog
Copy link
Contributor Author

sukidog commented Mar 26, 2016

No additional commits coming for this specific issue. More coming on Monday for a different one, though. Should probably use a separate PR for that, so please merge.

@c1728p9 c1728p9 merged commit d5a63b6 into ARMmbed:master Mar 26, 2016
@sukidog sukidog deleted the fix_gitnotinpath_error branch March 28, 2016 13:00
gerargz added a commit to microbit-foundation/DAPLink that referenced this pull request Jan 6, 2021
…ted to return LED to its default state and clear pending I2C interrupts
mbrossard pushed a commit to mbrossard/DAPLink that referenced this pull request Aug 5, 2021
…ted to return LED to its default state and clear pending I2C interrupts
c1728p9 pushed a commit to c1728p9/DAPLink that referenced this pull request Aug 14, 2021
…ted to return LED to its default state and clear pending I2C interrupts
mathias-arm pushed a commit to mathias-arm/DAPLink that referenced this pull request Aug 20, 2021
…ted to return LED to its default state and clear pending I2C interrupts
gaborcsapo pushed a commit to gaborcsapo/DAPLink that referenced this pull request Jun 29, 2022
…ted to return LED to its default state and clear pending I2C interrupts
gaborcsapo pushed a commit to gaborcsapo/DAPLink that referenced this pull request Jun 29, 2022
…ted to return LED to its default state and clear pending I2C interrupts
gaborcsapo pushed a commit to gaborcsapo/DAPLink that referenced this pull request Jun 29, 2022
…ted to return LED to its default state and clear pending I2C interrupts
gaborcsapo pushed a commit to gaborcsapo/DAPLink that referenced this pull request Jun 29, 2022
…ted to return LED to its default state and clear pending I2C interrupts
gaborcsapo pushed a commit to gaborcsapo/DAPLink that referenced this pull request Jun 29, 2022
…ted to return LED to its default state and clear pending I2C interrupts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants