Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align with KDFS 1.4.0 rounding update #548

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Align with KDFS 1.4.0 rounding update #548

merged 2 commits into from
Feb 13, 2025

Conversation

solidpixel
Copy link
Contributor

@solidpixel solidpixel commented Feb 6, 2025

Updates the codec rounding for sRGB to align with the KDFS 1.4.0 specification update, which reverts the alpha channel endpoint expansion behavior to match an earlier version of the specification.

This changes the alpha channel to use the same method ((x << 8) | 0x80) as the RGB channels. The previous behavior had alpha doing ((x << 8) | x). The impact of this change is differences in the LSB.

Fixes #547

@solidpixel solidpixel changed the title Align with KDFS 1.3.2 rounding update Align with KDFS 1.4.0 rounding update Feb 13, 2025
@solidpixel solidpixel merged commit 5f1f8a9 into main Feb 13, 2025
9 checks passed
@solidpixel solidpixel deleted the issue_534 branch February 13, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert sRGB rounding mode changes
1 participant