Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated files to add lsel == 0xFFFF where it was previously absent. #191

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Updated files to add lsel == 0xFFFF where it was previously absent. #191

merged 1 commit into from
Jun 7, 2022

Conversation

leo-barnes
Copy link
Collaborator

Closes #181
Will open a new issue to track changing the Xiph test content.

wantehchang
wantehchang approved these changes May 12, 2022
View reviewed changes
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

I wonder if files like animals_00_multilayer_a1lx.avif should be renamed because now they contain lsel (with layer_id=0xFFFF).

testFiles/Apple/multilayer_examples/animals_00_multilayer_a1op.avif.txt Show resolved Hide resolved
@tongyuantongyu tongyuantongyu mentioned this pull request May 15, 2022
Open
@leo-barnes
Copy link
Collaborator Author

I wonder if files like animals_00_multilayer_a1lx.avif should be renamed because now they contain lsel (with layer_id=0xFFFF).

I initially considered that as well, but I thought it made sense to have the files where lsel explicitly selects a layer call that out in the name.

@leo-barnes leo-barnes merged commit bde4abd into master Jun 7, 2022
@leo-barnes leo-barnes deleted the u/lbarnes/update_apple_multilayer_content branch September 10, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wantehchang wantehchang wantehchang approved these changes

@cconcolato cconcolato Awaiting requested review from cconcolato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update multi-layer content to conform to new 'lsel' wording
2 participants
@leo-barnes @wantehchang