Support for ensemble of pencil structure factor multifabs for the surface chemistry in do_2D mode #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now when using surface chemistry and do_2D, the surface chemistry structure factor is no longer a plane, but the average of many pencils.
Note there is now the strict requirement when n_ads_spec>0 and do_2D=1 that
-project_dir=2 (so each z plane is decoupled) and
-ads_wall_dir=1 (surface chemistry is the lo-y wall).
Thus, the surfaceCoverage structure factor is the average of many 1D x-pencils of surface coverage.