Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make using The_Comms_Arena() for particle communication opt-in #4286

Merged

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Jan 8, 2025

For mesh data it is better to use a small, separate Arena for communication. But, we found that for particle communication this approach uses too much memory (see the ImpactX Issue here: BLAST-ImpactX/impactx#769)

This restores the old default behavior (prior to PR #4175), but allows users to opt-in to using The_Comms_Arena if desired.

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@ax3l
Copy link
Member

ax3l commented Jan 9, 2025

Thank you, @atmyers !

Quick question, is it required to use the comms arena for GPU-aware MPI/GPU-direct comms or is it also opt-in independent of that?

@atmyers
Copy link
Member Author

atmyers commented Jan 9, 2025

It's independent of whether amrex.use_gpu_aware_mpi is on or not.

@atmyers atmyers merged commit 731efdc into AMReX-Codes:development Jan 9, 2025
75 checks passed
@ax3l
Copy link
Member

ax3l commented Jan 9, 2025

Thanks! I thought so, the prior control vars changed in this diff just confused me :)

@ax3l ax3l mentioned this pull request Jan 9, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants