Docker image for running generators #5
Conversation
Option for building docker image that runs generators
|
|
||
| # && rm -rf /var/lib/apt/lists/* | ||
| # Not sure I need libc6-i386 | ||
| # g*-multilib is an overkill but will be useful for compiling |
There was a problem hiding this comment.
In which scenarios do you think 32-bit compilations will be useful? I think we can remove them for simplicity.
| # g*-multilib is an overkill but will be useful for compiling | ||
|
|
||
| RUN update-alternatives --install /usr/bin/python python /usr/bin/python3.6 1 && \ | ||
| /usr/bin/python3 -m pip install --upgrade pip && \ |
There was a problem hiding this comment.
Haven't we updated pip already above?
| # Not sure I need libc6-i386 | ||
| # g*-multilib is an overkill but will be useful for compiling | ||
|
|
||
| RUN update-alternatives --install /usr/bin/python python /usr/bin/python3.6 1 && \ |
There was a problem hiding this comment.
Is this for making python point to python3? If so, we could instead install the python-is-python3 package.
|
|
||
| # Install OpenJDK-11 | ||
| RUN apt-get update && \ | ||
| apt-get install -y openjdk-11-jre-headless && \ |
There was a problem hiding this comment.
Why use a separate apt-get call for JDK?
| @@ -0,0 +1,61 @@ | |||
| FROM ubuntu:18.04 | |||
| @@ -9,6 +9,10 @@ Planning Competitions (IPC). | |||
| * Build single generator: ``cd assembly; make`` | |||
| * Test generators: ``sudo apt install python-tox && tox`` | |||
|
|
|||
| ## Docker instructions | |||
| * Build in Docker image: ``docker build -t pddl-generators .`` | |||
| * Run Docker container: ``docker run -ti -t pddl-generators`` | |||
There was a problem hiding this comment.
I think it would be good to use long option names for Docker beginners: --tag, --tty, --interactive
|
|
||
| COPY . . | ||
|
|
||
| RUN ./build_all save-logs |
There was a problem hiding this comment.
Why do you save the build logs? Couldn't they confuse users who just want to run the generators? You'll see the build output when the container is built, won't you?
|
My immediate reaction is "why do this when it's meant to be just placed inside of You game for that, @hectorpal ? It would mean that from a |
|
Good point. It'd be better to have it in planutils. I'll retract the PR and create one in planutils. |
|
If I understand Christian correctly, he suggests to keep the Dockerfile in this repo and then use it for adding the PDDL generators to planutils. I think this makes sense. |
|
That is indeed what I had in mind. Just need to wrap the completed docker into a singularity so that the generators can be used. This related at all to the changes @guicho271828 is running with over on #6 ? |
|
|
#6 is a simple attempt to make pddl-generators a unified unix-like tool. |
It's convenient for some people.