Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Darwin ARM64 publishing script #69

Closed
wants to merge 2 commits into from
Closed

Darwin ARM64 publishing script #69

wants to merge 2 commits into from

Conversation

rorp
Copy link

@rorp rorp commented Dec 19, 2022

I didn't find how to set up a cross build for Mac OS X, so I added a script similar to secp256k1-kmp-add-linuxarm64.sh.

@t-bast t-bast requested a review from sstone December 20, 2022 07:42
@sstone
Copy link
Member

sstone commented Dec 20, 2022

Hi rorp,
Thanks for this! Unfortunately I don't think we can merge this for the moment: we don't need it and would not use it, and it cannot be built and tested on our CI (see actions/runner-images#2187).
We made an exception for linux ARM64 binaries because it is something that we do need and use in production (and probably many AWS users too), but until Github CI adds proper M1/M2 macos support I'd rather not merge this PR but keep it open so other people who need this may be able to build the library themselves.

@rorp rorp mentioned this pull request Feb 18, 2023
Merged
@sstone
Copy link
Member

sstone commented Apr 13, 2023

Superseded by #77

@sstone sstone closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstone sstone Awaiting requested review from sstone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rorp @sstone