Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S1.22.scousepy #87

Merged
merged 6 commits into from
Sep 8, 2022
Merged

S1.22.scousepy #87

merged 6 commits into from
Sep 8, 2022

Conversation

aschmiedeke
Copy link
Contributor

Refitting completed. #23

Spectra look mostly good.

Some showed negatives on either side of strong emission peaks (49-52)
Two spectra required a high SNR (121 needed SNR=20 and 127 needed SNR=24)
I can provide screenshots if needed, but there was nothing really weird/unusual/surprising.

jdhenshaw
jdhenshaw previously approved these changes Jul 19, 2022
Copy link
Collaborator

@jdhenshaw jdhenshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fitting complete

@jdhenshaw jdhenshaw dismissed their stale review July 19, 2022 10:49

messed it up

Copy link
Collaborator

@jdhenshaw jdhenshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some examples of modifications to the fitting:

image

image

image

image

image

image

In general the fits are good. However, there is a tendency for ScousePy to want to default to broad components towards the blue shifted end. Mostly this is stuff that is "in the weeds", i.e. very close to the noise. There are cases where multiple components can be fit. Others, ScousePy just wants to fit a big broad thing. Given that: 1. this is ambiguous (could be single broad thing or multiple components); 2. This is not the main gas associated with Sgr B2; I am opting to fit where I can, and ignore them at other times. In general, in my experience, it is better to not fit a component if you get a fit that isn't quite right/physical/ambiguous and/or if you can get a reasonable fit, one that may potentially even improve the fits to the main group of components (in this case ~70km/s) then go for it.

@jdhenshaw jdhenshaw self-assigned this Jul 19, 2022
@aschmiedeke
Copy link
Contributor Author

Hey Jonny, I looked through your fits:

  • spectra 13, 18, 22, 41: I agree with your fits, they definitely are better.

  • spectra 40 and 43: I would suggest a hybrid fit, where we dump the two weak/broad components on the left hand side but keep two components for the main line, see the screenshots below. What do you think?

image (4)

image (5)

@jdhenshaw
Copy link
Collaborator

Hey Jonny, I looked through your fits:

  • spectra 13, 18, 22, 41: I agree with your fits, they definitely are better.
  • spectra 40 and 43: I would suggest a hybrid fit, where we dump the two weak/broad components on the left hand side but keep two components for the main line, see the screenshots below. What do you think?
image (4) image (5)

Yep ok, I can do this

Copy link
Collaborator

@jdhenshaw jdhenshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. Changes committed.

@jdhenshaw jdhenshaw merged commit 920c886 into ACES-CMZ:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants