WOMBATlite-sinking: Spatially variable sinking rates within the generic tracers version of WOMBAT-lite #15
Conversation
* Variable remineralisation rate (reminr) that increases as phytoplankton biomass increases and decreases with depth (emulating variable sinking rate of detritus) * Fixed a bug in the calculation of the minimum Fe quota of phytoplankton that reduced their dFe limitation * Added new diagnostics, particularly for terms contributing to the calculation of nutrient limitations
…My changes are: * new light diagnostics and chlorophyll light limitation diagnostic * made zooplankton epsilon (prey capture coefficient) variable from zooepsmin to zooepsmax * slowed dFe uptake by phytoplankton to min of 20% under darkness and nitrogen limitation * made remineralisation of detritus quadratic rather than linear to allow more detrital aggregation in gyres
There was a problem hiding this comment.
Thanks @pearseb. A couple of very minor comments/questions from an initial pass. As a general rule, I don't think we want to include commented out lines of code, especially if there is no comment explaining why they are commented out.
Regarding the vmove changes in generic_tracer_utils.F90, could we chat in person? I think we should definitely try to get these changes upstream into the main generic tracers repo and I have a few other things to discuss. I'll message you on Slack to sort out a time.
* Missed the retuning of dFe back to a minimum concentration at every timestep. This happens under "Additional operations on dissolved iron" Also took the opportunity to: * Add N and C conservation of mass checks * remove some unnecessary print statements * reduce dFe scavenging rates * Apply limitations to dFe uptake at night and when N is limiting * increase zooplankton quadratic mortality but halve their linear mortality * also reduced phytoplankton linear and quadratic mortality
|
Hi @dougiesquire, |
* Adjustment of zooepsmin and zooepsmax values from 0.025 - 0.5 to 0.01 - 0.1
pearseb
force-pushed
the
wombatlite-sinking
branch
from
2f94b42 to
e80a2f7
Compare
|
@pearseb, I don't think you've pushed all your changes. |
|
Sorry Dougie was running some extra tests. Will commit tomorrow!
From: Dougie Squire ***@***.***>
Date: Tuesday, 3 December 2024 at 8:45 pm
To: ACCESS-NRI/GFDL-generic-tracers ***@***.***>
Cc: Pearse J Buchanan ***@***.***>, Mention ***@***.***>
Subject: Re: [ACCESS-NRI/GFDL-generic-tracers] WOMBATlite-sinking: Spatially variable sinking rates within the generic tracers version of WOMBAT-lite (PR #15)
@pearseb<https://github.com/pearseb>, I don't think you've pushed all your changes. generic_tracer_utils.F90 hasn't changed since my last review
—
Reply to this email directly, view it on GitHub<#15 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA7GKGFE5DN73EPCTYEO4ML2DV4T3AVCNFSM6AAAAABRYCHXZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJUGAZDMNJTGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
* Explicit ALK source and sink terms within nested tilmestep * Using GOLDtridiag with vertical_movement for consistency with MOM6 * Variable epsilon of zooplankton with phy biomass and temp dependencies
…wer bounds on the DIC concentration that feeds into the omip2_co2calc subroutine. Setting upper and lower limits of the DIC that is fed into the subroutine does not preclude DIC concentrations from going higher or lower than those limits, but only ensures that the air-sea fluxes are reasonable.
|
Hi Dougie, |
…n the interior, and also added a max to Alk in the CO2 flux calculations
pearseb
force-pushed
the
wombatlite-sinking
branch
from
ce3d789 to
5017183
Compare
* Dissolution of CaCO3 based on detrital remin and saturation states of aragonite and calcite (Kwon et al., 2024) * Precipation of CaCO3 based on HCO3- to H+ ratio (Lehmann et al., in prep) * Sinking rate of material affected by ballasting, specifically CaCO3/Det ratio (Bach et al., 2016) These feedbacks can be turned on and off using the "caco3_dynamics" logical
Removed adic as a tracer because CaCO3 dynamics mean that it is not appropriate
Also altered some of the parameters.
…CaCO3 via saturation states (cal and ara) and detrius remin
…ing when vertical_movement==.true. Also: * Added "zooexcr" as an input parameter * Added "fbury" as a diagnostic, rathern than outputting det_sed_bury, detfe_sed_bury and caco3_sed_bury * Fixed a minor bug in the "fbury" array, which involved the wrong units
…de small edits to: * remove background dissolution of CaCO3 in absence of detritus
…ns that any NO3 and Alkalinity that is lost through burial is added back to the ocean budget via a surface flux in exactly the same location.
…estion, rather than at the same exact lon,lat location.
…rs option (line 3269 in generic_WOMBATlite.F90)
To include variable sinking rates in WOMBAT-lite within the generic tracers framework I have had to slightly extend the tri-diagonal (implicit) solver for vertical diffusion within the generic_tracer_utils.F90 file. Specifically, I have altered the "IOWtridiag" algorithm in the g_tracer_vertdiff_M subroutine. This algorithm previously solved only for the vertical movement of tracer within the water column, but did not account for the passing of tracer from the ocean model into a bottom reservoir. I have simply extended this algorithm to include the passing of some tracer into a bottom reservoir (i.e., sediment pool).
I have also made additions in the form of: