Add MaxAttempts trait to retry-able tests #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
reviewed
Jun 6, 2023
sharwell
reviewed
Jun 6, 2023
| Assert.Fail("This test should not have run a second time because the first run was successful."); | ||
| } | ||
| } | ||
| public void AutomaticRetryNotNeeded() => MaxAttemptsHelper.ThrowUnlessAttemptNumber(this.GetType(), MethodBase.GetCurrentMethod()!.Name, 1); |
There was a problem hiding this comment.
💭 With CallerFilePath and CallerLineNumber, you could probably get this down to:
MaxAttemptsHelper.ThrowUnlessAttemptNumber(1)
There was a problem hiding this comment.
Not for theories. But I agree we could remove the test class argument. File path would work until we have derived test classes that inherit tests. But this repo doesn't and isn't likely to have those.
I think I'll leave it as-is though for now.
sharwell
reviewed
Jun 6, 2023
| Assert.Fail("This test should not have run a second time because the first run was successful."); | ||
| } | ||
| } | ||
| public void AutomaticRetryNotNeeded(int arg) => MaxAttemptsHelper.ThrowUnlessAttemptNumber(this.GetType(), $"{MethodBase.GetCurrentMethod()!.Name}_{arg}", 1); |
There was a problem hiding this comment.
📝 The inclusion of arg here makes it more difficult to simplify
There was a problem hiding this comment.
I don't see a way to avoid it. You added it originally. 😉
sharwell
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added
MaxAttemptstrait makes tests groupable and filterable based on their retry attribution.I also clean up some unnecessary casts and simplify the retry tests.