Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PipeReader position after an async deserialization #240

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

AArnott
Copy link
Owner

@AArnott AArnott commented Jan 29, 2025

Prior to this fix, the MessagePackSerializer.DeserializeAsync<T>(PipeReader, ...) methods would leave the PipeReader in an undefined state.

Prior to this fix, the `MessagePackSerializer.DeserializeAsync<T>(PipeReader, ...)` methods would leave the `PipeReader` in an undefined state.
@AArnott AArnott requested a review from Copilot January 29, 2025 14:01

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • src/Nerdbank.MessagePack/net8.0/PublicAPI.Unshipped.txt: Language not supported
  • src/Nerdbank.MessagePack/netstandard2.0/PublicAPI.Unshipped.txt: Language not supported
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.34%. Comparing base (7c0b00e) to head (997b760).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/Nerdbank.MessagePack/MessagePackAsyncReader.cs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
+ Coverage   84.32%   84.34%   +0.01%     
==========================================
  Files         164      164              
  Lines       12889    12907      +18     
  Branches     1403     1405       +2     
==========================================
+ Hits        10869    10886      +17     
- Misses       1991     1992       +1     
  Partials       29       29              
Flag Coverage Δ
Linux 82.56% <95.23%> (-0.01%) ⬇️
Windows 84.30% <95.23%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AArnott AArnott merged commit 4160397 into main Jan 29, 2025
5 checks passed
@AArnott AArnott deleted the fixPipeReaderUse branch January 29, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant