Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode strings incrementally during async deserialization #211

Merged
merged 4 commits into from
Jan 4, 2025

Conversation

AArnott
Copy link
Owner

@AArnott AArnott commented Jan 4, 2025

This doesn't change how we work when interning strings.
It also doesn't incrementally encode strings during async serialization. But we could add that if needed.

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 95.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.23%. Comparing base (9884932) to head (b01e5c3).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...Nerdbank.MessagePack/MessagePackStreamingReader.cs 80.00% 2 Missing ⚠️
src/Nerdbank.MessagePack/SequencePool`1.cs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
+ Coverage   83.82%   84.23%   +0.41%     
==========================================
  Files         157      157              
  Lines       12596    12646      +50     
  Branches     1351     1346       -5     
==========================================
+ Hits        10558    10652      +94     
+ Misses       2016     1972      -44     
  Partials       22       22              
Flag Coverage Δ
Linux 82.29% <92.53%> (+0.35%) ⬆️
Windows 84.21% <95.71%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AArnott AArnott merged commit c8a4149 into main Jan 4, 2025
4 checks passed
@AArnott AArnott deleted the streamingStrings branch January 4, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant