Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle ctor parameters named by the serialized name #209

Merged
merged 2 commits into from
Dec 29, 2024
Merged

Conversation

AArnott
Copy link
Owner

@AArnott AArnott commented Dec 29, 2024

Fixes #208

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.84%. Comparing base (f0709e4) to head (5331768).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...nk.MessagePack.Tests/MessagePackSerializerTests.cs 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
+ Coverage   83.82%   83.84%   +0.01%     
==========================================
  Files         157      157              
  Lines       12575    12596      +21     
  Branches     1348     1351       +3     
==========================================
+ Hits        10541    10561      +20     
- Misses       2011     2012       +1     
  Partials       23       23              
Flag Coverage Δ
Linux 81.94% <96.29%> (+0.02%) ⬆️
Windows 83.80% <96.29%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

We don't have any tests that say this is a bad idea, so I'm considering that by default it's a good idea, until we have a test that shows otherwise.
@AArnott AArnott enabled auto-merge December 29, 2024 22:28
@AArnott AArnott merged commit 9884932 into main Dec 29, 2024
3 of 4 checks passed
@AArnott AArnott deleted the fix208 branch December 29, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate Key Exception when serializing struct with PropertyShape attributes
2 participants