Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MessagePackString class #187

Conversation

AArnott
Copy link
Owner

@AArnott AArnott commented Dec 21, 2024

This helps authors of custom converters to reduce string allocation and encoding costs.

Closes #183

@AArnott AArnott added the enhancement New feature or request label Dec 21, 2024
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 95.09804% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.59%. Comparing base (9ed23f7) to head (51bcde1).

Files with missing lines Patch % Lines
src/Nerdbank.MessagePack/MessagePackReader.cs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   83.52%   83.59%   +0.07%     
==========================================
  Files         153      155       +2     
  Lines       12243    12345     +102     
  Branches     1250     1264      +14     
==========================================
+ Hits        10226    10320      +94     
- Misses       1994     2003       +9     
+ Partials       23       22       -1     
Flag Coverage Δ
Linux 81.67% <95.09%> (+0.09%) ⬆️
Windows 83.58% <95.09%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This helps authors of custom converters to reduce string allocation and encoding costs.
@AArnott AArnott force-pushed the 183-provide-api-to-reduce-string-allocations-in-user-defined-custom-converters branch from 51bcde1 to 2e3cc6b Compare December 21, 2024 19:52
@AArnott AArnott enabled auto-merge December 21, 2024 19:52
@AArnott AArnott merged commit 9987381 into main Dec 21, 2024
2 checks passed
@AArnott AArnott deleted the 183-provide-api-to-reduce-string-allocations-in-user-defined-custom-converters branch December 21, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide API to reduce string allocations in user-defined custom converters
1 participant