-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmarks for not bool/float/double primitive arrays. #145
Conversation
CommitId:3ba732774238b9172135fb2ac700d3891789ea4e
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I'll take the change, but can you first add a code comment on the new benchmark class explaining what multiple category means and why it's useful?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
==========================================
+ Coverage 76.81% 76.91% +0.10%
==========================================
Files 140 140
Lines 9968 9968
Branches 1385 1385
==========================================
+ Hits 7657 7667 +10
+ Misses 1906 1897 -9
+ Partials 405 404 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Current benchmark code for
long[]
only examines the values which would be encoded into 9 bytes in most cases.This might lead to over-optimization on .NET runtime level and CPU arch level.