Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for string interning #144

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

AArnott
Copy link
Owner

@AArnott AArnott commented Dec 4, 2024

Closes #143

@AArnott AArnott added the enhancement New feature or request label Dec 4, 2024
@AArnott AArnott linked an issue Dec 4, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 72.41379% with 16 lines in your changes missing coverage. Please review.

Project coverage is 76.50%. Comparing base (1851e9b) to head (e51ac7b).

Files with missing lines Patch % Lines
...bank.MessagePack/Converters/PrimitiveConverters.cs 33.33% 9 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
- Coverage   76.60%   76.50%   -0.10%     
==========================================
  Files         139      140       +1     
  Lines        9898     9956      +58     
  Branches     1374     1385      +11     
==========================================
+ Hits         7582     7617      +35     
- Misses       1912     1927      +15     
- Partials      404      412       +8     
Flag Coverage Δ
Linux 76.50% <72.41%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AArnott AArnott force-pushed the 143-support-for-string-interning branch from e51ac7b to 2ad95a9 Compare December 4, 2024 03:37
@AArnott AArnott merged commit e4e5c37 into main Dec 4, 2024
2 checks passed
@AArnott AArnott deleted the 143-support-for-string-interning branch December 4, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for string interning
1 participant