Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of getter-only properties on [Key] types #127

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Conversation

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 58.17308% with 87 lines in your changes missing coverage. Please review.

Project coverage is 78.87%. Comparing base (d0074f2) to head (12ac63b).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...sagePack.Analyzers.Tests/MigrationAnalyzerTests.cs 17.28% 67 Missing ⚠️
...k.MessagePack.Analyzers/KeyAttributeUseAnalyzer.cs 70.83% 5 Missing and 2 partials ⚠️
...Nerdbank.MessagePack.Tests/ObjectsAsArraysTests.cs 77.27% 5 Missing ⚠️
...essagePack.Analyzers.CodeFixes/MigrationCodeFix.cs 75.00% 2 Missing and 1 partial ⚠️
...Nerdbank.MessagePack.Analyzers/ReferenceSymbols.cs 62.50% 2 Missing and 1 partial ⚠️
...st/Nerdbank.MessagePack.Tests/ObjectsAsMapTests.cs 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   78.98%   78.87%   -0.12%     
==========================================
  Files         130      130              
  Lines        8129     8223      +94     
  Branches     1123     1127       +4     
==========================================
+ Hits         6421     6486      +65     
- Misses       1378     1405      +27     
- Partials      330      332       +2     
Flag Coverage Δ
Linux 78.87% <58.17%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AArnott AArnott merged commit 3ac0d30 into main Nov 26, 2024
2 of 4 checks passed
@AArnott AArnott deleted the adoptionFixes branch November 26, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant