Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix async serialization corruption #111

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Fix async serialization corruption #111

merged 3 commits into from
Nov 18, 2024

Conversation

AArnott
Copy link
Owner

@AArnott AArnott commented Nov 18, 2024

Fix a mixed use of sync and async writers that led to data corruption in the serialized output.

Also:

  • Add logging of async msgpack in tests.
  • Fix T4 compilation warnings.

@AArnott AArnott enabled auto-merge November 18, 2024 16:21
@AArnott AArnott merged commit 7142eb3 into main Nov 18, 2024
2 checks passed
@AArnott AArnott deleted the fixes branch November 18, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AArnott