fix(): type 'string' is not assignable to type 'boolean' in Inputs

A-l-y-l-e · Jan 6, 2024 · cdd5569 · cdd5569
1 parent 0cb996a
commit cdd5569
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/src/lib/checkbox/checkbox.ts b/src/lib/checkbox/checkbox.ts
@@ -295,7 +295,7 @@ export class LyCheckbox extends LyCheckboxMixinBase implements WithStyles,
    */
   @Input()
   get checked(): boolean { return this._checked; }
-  set checked(val: boolean) {
+  set checked(val: BooleanInput) {
     const newVal = coerceBooleanProperty(val);
     if (newVal !== this.checked) {
       this._checked = newVal;
@@ -332,7 +332,7 @@ export class LyCheckbox extends LyCheckboxMixinBase implements WithStyles,
   get disabled() {
     return this._disabled;
   }
-  set disabled(val: boolean) {
+  set disabled(val: BooleanInput) {
     const newVal = coerceBooleanProperty(val);
     if (newVal !== this.disabled) {
       this._disabled = newVal;

diff --git a/src/lib/typography/typography.directive.ts b/src/lib/typography/typography.directive.ts
@@ -1,13 +1,13 @@
 import { Directive, ElementRef, Renderer2, Input, OnInit, OnChanges } from '@angular/core';
 import { LyTheme2,
-  toBoolean,
   ThemeVariables,
   mixinStyleUpdater,
   mixinColor,
   StyleCollection,
   StyleTemplate,
   lyl,
   StyleRenderer} from '@alyle/ui';
+import { BooleanInput, coerceBooleanProperty } from '@angular/cdk/coercion';
 
 export interface LyTypographyTheme {
   /** Styles for Typography Component */
@@ -107,8 +107,8 @@ export class LyTypography extends LyTypographyMixinBase implements OnInit, OnCha
 
   /** The text will truncate with an ellipsis. */
   @Input()
-  set noWrap(val: boolean) {
-    const newValue = toBoolean(val);
+  set noWrap(val: BooleanInput) {
+    const newValue = coerceBooleanProperty(val);
     if (newValue) {
       this._noWrapClass = this._theme.addSimpleStyle('lyTyp.noWrap', {
         overflow: 'hidden',
@@ -126,8 +126,8 @@ export class LyTypography extends LyTypographyMixinBase implements OnInit, OnCha
   }
 
   @Input()
-  set gutter(val: boolean) {
-    const newVal = toBoolean(val);
+  set gutter(val: BooleanInput) {
+    const newVal = coerceBooleanProperty(val);
     if (newVal !== this.gutter) {
       this._gutter = newVal;
       this.sRenderer.toggleClass(this.classes.gutter, newVal);
@@ -138,8 +138,8 @@ export class LyTypography extends LyTypographyMixinBase implements OnInit, OnCha
   }
 
   @Input()
-  set gutterTop(val: boolean) {
-    const newVal = toBoolean(val);
+  set gutterTop(val: BooleanInput) {
+    const newVal = coerceBooleanProperty(val);
     if (newVal !== this.gutterTop) {
       this._gutterTop = newVal;
       this.sRenderer.toggleClass(this.classes.gutterTop, newVal);
@@ -150,8 +150,8 @@ export class LyTypography extends LyTypographyMixinBase implements OnInit, OnCha
   }
 
   @Input()
-  set gutterBottom(val: boolean) {
-    const newVal = toBoolean(val);
+  set gutterBottom(val: BooleanInput) {
+    const newVal = coerceBooleanProperty(val);
     if (newVal !== this.gutterBottom) {
       this._gutterBottom = newVal;
       this.sRenderer.toggleClass(this.classes.gutterBottom, newVal);