Added product ID to target single products #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 19, 2017 19:53
added product ID at the end of the name to target every products in archive pages
added product ID to target single products
Mantish
requested changes
Apr 20, 2017
| // This handles < 2.4.0 bw compatibility where text attributes were not sanitized. | ||
| $checked = sanitize_title( $checked_value ) === $checked_value ? checked( $checked_value, sanitize_title( $value ), false ) : checked( $checked_value, $value, false ); | ||
|
|
||
| $input_name = 'attribute_' . esc_attr( $name ) ; | ||
| $esc_value = esc_attr( $value ); | ||
| $id = esc_attr( $name . '_v_' . $value ); | ||
| $id = esc_attr( $name . '_v_' . $value . $product->id ); //added product ID at the end of the name to target single products |
There was a problem hiding this comment.
we should use ->get_id() instead of ->id as this is deprecated in the latest woocommerce version
Replaced deprecated $product->id() by $product->get_id()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using your plugin for displaying variations in archive pages in conjunction with "Woocommerce Add to cart Ajax for variable products" plugin.
I've found a problem when selecting variable atributes in archive pages for different products with same atributes because inputs of different products has the same name in all products, and the javascript wasn't working well (was always targeting the input of the first product).
I solved it adding some customization in your variable.php, in print_attribute_radio function, adding product ids to inputs id names. That way, javascript can properly target the product imputs from every product. Maybe you can update your plugin with a similar modification.