Added support for attributes on the Abbreviation element. #6
Conversation
|
I like it. Would it be possible to add another test case to demonstrate use?? The expected and used string can be inside the test case itself. |
|
Will do! |
Ambient-Impact
force-pushed
the
attributes
branch
from
3811a8f to
55abf65
Compare
|
I don't have PHP 7.4 locally (only have 7.3), so bear with me through a couple force pushes to see if the test actually works. :P |
Ambient-Impact
force-pushed
the
attributes
branch
2 times, most recently
from
3a59a4b to
96340a7
Compare
|
@Ambient-Impact: No worries on the PHP version. Also seems like the CI/CD wasn't set to run automatically - sorry about that. Let me know when you think it's ready to go. |
Ambient-Impact
force-pushed
the
attributes
branch
from
96340a7 to
36bee8d
Compare
|
Just fixed a comment typo in the test. I don't see anything else missing so it should be fine on my end. |
|
Thanks again @Ambient-Impact - taught me how to incorporate attributes into extensions as well! |
|
|
|
Honestly, I'm still poking around and figuring out how CommonMark works for a project, so I'm learning as well. 😄 |
|
lol - Know how that goes. The CommonMark library is one of the ones we sponsor. The main developer seems pretty approachable. I did add this to the CommonMark discussion board as well to see if they would consider it being an actual part of the spec as well. If you haven't already, highly recommend either or both of them for resources. |
|
I've talked a bit with the CommonMark people (Colin, Mark), and they do seem pretty helpful. Good luck with the spec stuff! |
This allows for both in-content attributes defined by content authors and also manipulation in event listeners.