-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use Commonmark 2.0 #12
Conversation
todo: update markdown files for breaking changes in commonmark html rendering
still need to update the markdown files
Hey @Ambient-Impact wanted to give you a chance to review these changes for possible impact to you. All of the tests still pass and no new tests were added. It looks like CommonMark 2+ changes the permalink header convention though. |
I appreciate the heads up. I'm up to my eyeballs with work at the moment as we launched our project a few weeks ago, so I don't have time right now to look at all of this. Since we use the Markdown Drupal module and it's rather slow to update its support of CommonMark versions, I doubt we'll be moving to CommonMark 2 anytime soon. 😅 On the plus side, the many abbreviations are working pretty well after launch. |
Glad the project is progressing! I'll probably go ahead and merge and release. It'll be a new major, so, should be easy to deal there. 😃 Thanks for all the contributions and using the project! |
Thanks! If you want to see the output of this extension along with our auto-matching stuff, check this article out.
Major version bump makes sense, hope it goes well. If I have time at a later date, I'll see about our upgrade path and may contribute if needed. Good luck! |
This is a work in progress PR for verifying abbreviations will work with Commonmark 2.*.
https://github.com/8fold/commonmark-accordions will also need to be verified and updated accordingly.