Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use Commonmark 2.0 #12

Merged
merged 14 commits into from
Aug 15, 2021
Merged

Update to use Commonmark 2.0 #12

merged 14 commits into from
Aug 15, 2021

Conversation

joshbruce
Copy link
Member

This is a work in progress PR for verifying abbreviations will work with Commonmark 2.*.

https://github.com/8fold/commonmark-accordions will also need to be verified and updated accordingly.

@joshbruce joshbruce self-assigned this Aug 6, 2021
@joshbruce joshbruce marked this pull request as ready for review August 6, 2021 22:35
@joshbruce
Copy link
Member Author

joshbruce commented Aug 6, 2021

Hey @Ambient-Impact wanted to give you a chance to review these changes for possible impact to you.

All of the tests still pass and no new tests were added.

It looks like CommonMark 2+ changes the permalink header convention though.

@joshbruce joshbruce changed the title [WIP]: Update to use Commonmark 2.0 Update to use Commonmark 2.0 Aug 6, 2021
@Ambient-Impact
Copy link
Contributor

Hey @Ambient-Impact wanted to give you a chance to review these changes for possible impact to you.

All of the tests still pass and no new tests were added.

It looks like CommonMark 2+ changes the permalink header convention though.

I appreciate the heads up. I'm up to my eyeballs with work at the moment as we launched our project a few weeks ago, so I don't have time right now to look at all of this. Since we use the Markdown Drupal module and it's rather slow to update its support of CommonMark versions, I doubt we'll be moving to CommonMark 2 anytime soon. 😅 On the plus side, the many abbreviations are working pretty well after launch.

@joshbruce
Copy link
Member Author

Glad the project is progressing!

I'll probably go ahead and merge and release. It'll be a new major, so, should be easy to deal there. 😃

Thanks for all the contributions and using the project!

@Ambient-Impact
Copy link
Contributor

Glad the project is progressing!

Thanks! If you want to see the output of this extension along with our auto-matching stuff, check this article out.

I'll probably go ahead and merge and release. It'll be a new major, so, should be easy to deal there. 😃

Thanks for all the contributions and using the project!

Major version bump makes sense, hope it goes well. If I have time at a later date, I'll see about our upgrade path and may contribute if needed. Good luck!

@joshbruce joshbruce merged commit da4da1b into master Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants