distage-framework-docker: Use default Docker.ClientConfig if dockerconfig section is not found, add makeConfigWithDefault, wireConfig, wireConfigWithDefault to ConfigModuleDef
#1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… config section is not found, add `wireConfig`, `wireConfigWithDefault` to `ConfigModuleDef`
neko-kai
changed the title
Docker.ClientConfig if dockerconfig section is not found, add wireConfig, wireConfigWithDefault to ConfigModuleDefDocker.ClientConfig if dockerconfig section is not found, add makeConfigWithDefault, wireConfig, wireConfigWithDefault to ConfigModuleDef
Codecov Report
@@ Coverage Diff @@
## develop #1075 +/- ##
===========================================
- Coverage 55.93% 55.82% -0.12%
===========================================
Files 381 381
Lines 6940 6956 +16
Branches 362 359 -3
===========================================
+ Hits 3882 3883 +1
- Misses 3058 3073 +15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make
include "docker-reference.conf"optional/cc @coreyoconnor