distage-testkit: Add TestConfig#debugOutput, rename TestConfig#testRunnerLogLevel->logLevel, choose lowest logLevel among all tests envs for test runner logs (allow silencing config load log).
#1074
Conversation
…tRunnerLogLevel`->`logLevel`, choose lowest `logLevel` among all tests envs for test runner logs (allow silencing config load log). * system property `izumi.distage.testkit.debug` sets testkit debug logs to info, instead of setting logger to Debug level * log how many envs were merged if any * exclude _all_ components of runtimeLocator from subsequent plans * fixed memoizedConfig for multiple test effect types * update TestConfig doc
Codecov Report
@@ Coverage Diff @@
## develop #1074 +/- ##
===========================================
+ Coverage 55.93% 56.03% +0.09%
===========================================
Files 381 381
Lines 6940 6951 +11
Branches 362 364 +2
===========================================
+ Hits 3882 3895 +13
+ Misses 3058 3056 -2 |
| val runtimeLogger = EarlyLoggers.makeLateLogger(RawAppArgs.empty, memoizedEnvLogger, config, env.logLevel, defaultLogFormatJson = false)( | ||
| "memoEnv" -> memoEnv.hashCode() | ||
| ) | ||
| val configLoadLogger = IzLogger(memoEnv.logLevel).withCustomContext("phase" -> "testRunner") |
There was a problem hiding this comment.
Hm, but with such behavior you cannot control config logger log level via debug property.
There was a problem hiding this comment.
@Caparow Yeah, because it's on by default - you should bump logLevel to filter it out. I could add a debug property to disable config logs, but i think it wouldn't be that useful - it's kinda hard to add persistent system properties everywhere, if you're the kind of person who wants zero-log testing
There was a problem hiding this comment.
Or we can use an enum instead of bool after all - then you could disable config log by setting Silent
There was a problem hiding this comment.
@neko-kai ah, I just thought that we want to make config loader with test runner logger instead of environment one (because making a config is a part of env preparation rather than test run). Anyway, it's not necessary since we already reduced the number of logs for config loader, and in the vast majority of cases we will have only one config loader message.
There was a problem hiding this comment.
Ok in that case let's merge as-is
izumi.distage.testkit.debugsets testkit debug logs to info, instead of setting logger to Debug level