Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distage-framework-docker: rename DockerContainerModule to DockerSupportModule #1070

Merged
merged 2 commits into from
May 21, 2020

Conversation

neko-kai
Copy link
Member

DockerContainerModule is misnamed - the module adds the infrastructure required to launch docker containers, not adds a specific container

…rtModule

DockerContainerModule is misnamed - the module adds the infrastructure required to launch docker containers, not adds a specific container
@neko-kai neko-kai requested a review from pshirshov May 20, 2020 22:12
@codecov-commenter
Copy link

Codecov Report

Merging #1070 into develop will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #1070      +/-   ##
===========================================
- Coverage    55.68%   55.66%   -0.02%     
===========================================
  Files          380      380              
  Lines         6909     6909              
  Branches       357      364       +7     
===========================================
- Hits          3847     3846       -1     
- Misses        3062     3063       +1     

@neko-kai neko-kai merged commit 1c4e713 into develop May 21, 2020
@neko-kai neko-kai deleted the feature/rename-docker-container-module branch May 21, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants