Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GCMode to Roots #1059

Merged
merged 4 commits into from
May 23, 2020
Merged

Rename GCMode to Roots #1059

merged 4 commits into from
May 23, 2020

Conversation

neko-kai
Copy link
Member

@neko-kai neko-kai commented May 17, 2020

  • Make NonEmptySet an immutable Set
  • add DIKey.apply short-hand (write DIKey[T]/DIKey[T]("x") instead of DIKey.get[T]/DIKey.get[T].named("x")

@neko-kai neko-kai requested a review from pshirshov May 17, 2020 16:38
@neko-kai neko-kai marked this pull request as ready for review May 20, 2020 22:10
@neko-kai neko-kai force-pushed the feature/rename-gcmode-to-roots branch from bf05f5f to 70b07fd Compare May 20, 2020 22:14
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2020

Codecov Report

Merging #1059 into develop will increase coverage by 0.01%.
The diff coverage is 79.03%.

@@             Coverage Diff             @@
##           develop    #1059      +/-   ##
===========================================
+ Coverage    55.92%   55.93%   +0.01%     
===========================================
  Files          381      381              
  Lines         6967     6970       +3     
  Branches       365      364       -1     
===========================================
+ Hits          3896     3899       +3     
  Misses        3071     3071              

neko-kai added 2 commits May 23, 2020 13:42
* Make NonEmptySet an immutable Set
@neko-kai neko-kai force-pushed the feature/rename-gcmode-to-roots branch from 70b07fd to 3b020c9 Compare May 23, 2020 12:42
@neko-kai neko-kai merged commit d68c274 into develop May 23, 2020
@neko-kai neko-kai deleted the feature/rename-gcmode-to-roots branch May 23, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants