Add bio parallel syntax #1041
Add bio parallel syntax #1041
Conversation
Adriani277
force-pushed
the
add-bio-parallel-syntax
branch
from
ad6950b to
dedfd27
Compare
Adriani277
force-pushed
the
add-bio-parallel-syntax
branch
from
dedfd27 to
11aced3
Compare
There was a problem hiding this comment.
@Adriani277 Thank you! 🙏 Everything is good, except I'd rather avoid symbolic aliases entirely. An exception was made for *> & <*(but e.g. not for >>=) due to them being exceedingly common, but parallel combinators are comparatively much rarer.
|
@neko-kai No problem, will remove them |
| x[zio.ZIO](zio.UIO.succeed(()), zio.UIO.succeed(())) | ||
| } | ||
|
|
||
| "BIOAsync.race is callable" in { |
There was a problem hiding this comment.
@Adriani277 BIOParallel ops should also be available when only BIOAsync is visible, the easiest way to do it would be to just copypaste them down into BIOAsync(3)Ops (as is done for BIOMonad ops)
| @@ -1,12 +1,52 @@ | |||
| package izumi.fundamentals.bio.test | |||
|
|
|||
| import izumi.functional.bio.{BIO, BIOArrow, BIOAsk, BIOBifunctor3, BIOFork, BIOFork3, BIOFunctor, BIOLocal, BIOMonad, BIOMonad3, BIOMonadAsk, BIOMonadError, BIOPrimitives, BIOPrimitives3, BIOProfunctor, BIOTemporal, BIOTemporal3, F} | |||
| import izumi.functional.bio.{BIO, BIOArrow, BIOAsk, BIOAsync, BIOBifunctor3, BIOFork, BIOFork3, BIOFunctor, BIOLocal, BIOMonad, BIOMonad3, BIOMonadAsk, BIOMonadError, BIOParallel, BIOPrimitives, BIOPrimitives3, BIOProfunctor, BIOTemporal, BIOTemporal3, F} | |||
There was a problem hiding this comment.
you may want to move the imports for BIOAsync/BIOParallel down into their respective tests, since they impact the visibility of operators and may result in false positive results
| import izumi.functional.bio.BIOAsync3 | ||
|
|
||
| def x[F[-_, +_, +_]: BIOAsync3](a: F[Any, Nothing, Unit], b: F[Any, Nothing, Unit]) = { | ||
| a zipPar b |
There was a problem hiding this comment.
@Adriani277 This keeps working because of the BIOParallel import above, with it cleaned up it fails.
There was a problem hiding this comment.
Ah apologies, seems I missed that BIOParallel import. BIOSync should have been working without the BIOParallel import. I will try to investigate why this is not working
@neko-kai The only reason I can see for it not working is due to BIOAsyncOps not extending BIOParallelOps but I am not sure how to get that to work since BIOAsyncOps already extends BIOOps.
Any tips?
Managed to get it working by making BIOParallel a trait.
Will push the changes tomorrow morning
closes #1034