Remove ModuleBase#Self type member, use implicit priority-based scheme instead #1036
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How it works: for a type
ModuleDef <: Module <: ModuleBase
the priority of companion object searches isModuleDef -> Module -> ModuleBase
such that if we launch a search forModuleMake[ModuleDef, T]
, companion object ofModule
will have a higher priority that companion object ofModuleBase
resulting in the instanceModuleMake[Module, Module]
.Unfortunately we also have to add an implicit rule transforming any
ModuleMake.Aux[X, T]
intoModuleMake[T]
- to be able to use instance ofModuleMake[T]
when there's only an instance ofModuleMake.Aux[X, T]
- because theX
parameter shouldn't stop us from using the instance, it's only there to make the search happen in the companion objects, i.e. it's a pure phantom parameter, but there's no way to express it in Scala currently.