Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence 2.13 collection warnings #1027

Merged
merged 9 commits into from
May 11, 2020
Merged

Conversation

neko-kai
Copy link
Member

Postpone updating to 2.13.2 due to bug scala/bug#11968 that makes it impossible to compile the project on that version

@neko-kai neko-kai requested a review from pshirshov April 30, 2020 18:39
@neko-kai
Copy link
Member Author

@nowarn silencer not yet available on 2.13.1... ghik/silencer#52

@neko-kai neko-kai marked this pull request as draft May 9, 2020 19:48
@neko-kai neko-kai force-pushed the feature/update-to-scala-2.13.2 branch from dd6aa9a to 283e7bf Compare May 11, 2020 12:24
@neko-kai
Copy link
Member Author

And seems like it wouldn't be available soon so moving back to @silent

@neko-kai neko-kai changed the title Replace silencer @silent with @scala.annotation.nowarn and get rid of 2.13 collection warnings Silence 2.13 collection warnings May 11, 2020
@neko-kai neko-kai marked this pull request as ready for review May 11, 2020 13:16
@codecov-io
Copy link

codecov-io commented May 11, 2020

Codecov Report

Merging #1027 into develop will increase coverage by 0.04%.
The diff coverage is 57.14%.

@@             Coverage Diff             @@
##           develop    #1027      +/-   ##
===========================================
+ Coverage    54.44%   54.48%   +0.04%     
===========================================
  Files          404      404              
  Lines         8600     8601       +1     
  Branches       495      496       +1     
===========================================
+ Hits          4682     4686       +4     
+ Misses        3918     3915       -3     

@neko-kai neko-kai merged commit 6bd9cfd into develop May 11, 2020
@neko-kai neko-kai deleted the feature/update-to-scala-2.13.2 branch May 11, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants