Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

tests: E2E Advanced options > Add new owner #3953

Merged
merged 9 commits into from
Jul 11, 2022
Merged

Conversation

francovenica
Copy link
Contributor

@francovenica francovenica commented Jun 9, 2022

Covers "Add new owner" modal for 1/N policy including:

  • tests form validation
  • error messages
  • gas estimations
  • changing threshold

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

Deployment links

Mainnet     🟣 Polygon     🟠 Rinkeby

@coveralls
Copy link

coveralls commented Jun 9, 2022

Pull Request Test Coverage Report for Build 2640895508

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 40.46%

Totals Coverage Status
Change from base Build 2628194545: 0.0%
Covered Lines: 4395
Relevant Lines: 9937

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@DiogoSoaress DiogoSoaress marked this pull request as draft July 8, 2022 15:26
@DiogoSoaress DiogoSoaress changed the title WIP adv options tests: E2E Advanced options > Add new owner Jul 8, 2022
@DiogoSoaress DiogoSoaress marked this pull request as ready for review July 8, 2022 17:33
@DiogoSoaress DiogoSoaress requested a review from katspaugh July 8, 2022 17:33
@DiogoSoaress DiogoSoaress merged commit 683f49c into dev Jul 11, 2022
@DiogoSoaress DiogoSoaress deleted the e2e-adv-options branch July 11, 2022 07:54
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants