fix: remove provider on disconnect

[iamacook]

What it solves

Resolves #3938

How this PR fixes it

Removal of the last provider cache occurs with clicking disconnect.

It was previously removed when onboard was totally disconnected and the provider store was empty, which occurs when switching chain. We didn't experience this bug before as the removal of the wrong key was attempted.

How to test it

Connect a wallet and:

1. switch to a supported chain and observe successful reconnection.
2. switch to an unsupported chain and observe no reconnection. Switching back to a supported chain should successfully reconnect,

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[katspaugh]

What if you disconnect from the wallet itself?

Doesn't onboard have a specific disconnect event?

[github-actions]

Deployment links

⚪ Mainnet     🟣 Polygon     🟠 Rinkeby

[coveralls]

Pull Request Test Coverage Report for Build 2462374324

• 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 36.621%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/components/AppLayout/Header/index.tsx	0	1	0.0%

Totals
Change from base Build 2461049552:	0.0%
Covered Lines:	3847
Relevant Lines:	9545

---

💛 - Coveralls

[iamacook]

What if you disconnect from the wallet itself?

Doesn't onboard have a specific disconnect event?

Sadly it doesn't. I think it's current implementation flows better than before though.

[usame-algan]

🚀

[katspaugh]

Thanks!

[francovenica]

For what I see It only works with MM. Is this how is expected to work?

I tried WC, Trezor and Ledger and those do not keep the connection, for example going from rinkeby to mainnet since both networks support all the wallets mentioned.
If WC, Trezor and Ledger don't allow this "re connection" between networks let me know and we can ignore it for this ticket

[iamacook]

I tried WC, Trezor and Ledger and those do not keep the connection, for example going from rinkeby to mainnet since both networks support all the wallets mentioned. If WC, Trezor and Ledger don't allow this "re connection" between networks let me know and we can ignore it for this ticket

I'm pretty sure you're correct. WC sessions are chain specific and hardware wallets do not allow for switching networks.

[katspaugh]

WC sessions are chain specific

This might be true in our case, but most other apps allow switching the chain within a single WC session.

[iamacook]

This might be true in our case, but most other apps allow switching the chain within a single WC session.

Switching via the wallet is supported and prod/this PR does this:

Changing network via wallet (maintains connection):

This PR:

Prod.:

Changing network via Safe (does not reconnect):

PR:

Prod.:

WC doesn't support the wallet_switchEthereumChain method, so it's not possible via the Safe.