Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

fix: Added a blank space to align buttons in the Share Safe App Page #3931

Merged
merged 6 commits into from
Jun 9, 2022

Conversation

DaniSomoza
Copy link
Contributor

@DaniSomoza DaniSomoza commented Jun 6, 2022

What it solves

Resolves #3899

How this PR fixes it

Added a <Spacer /> component to align buttons in the Share Safe App Page

Captura de pantalla 2022-06-06 a las 15 26 50

@github-actions
Copy link

github-actions bot commented Jun 6, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@DaniSomoza DaniSomoza requested review from dasanra and yagopv June 6, 2022 13:15
@github-actions
Copy link

github-actions bot commented Jun 6, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

github-actions bot commented Jun 6, 2022

Deployment links

Mainnet     🟣 Polygon     🟠 Rinkeby

dasanra
dasanra previously approved these changes Jun 6, 2022
@DaniSomoza DaniSomoza linked an issue Jun 7, 2022 that may be closed by this pull request
Base automatically changed from show-safes-from-localstorage-no-wallet-connected to dev June 7, 2022 11:00
@JagoFigueroa
Copy link

beautifully aligned señor, mis dieses for you ;)

@DaniSomoza DaniSomoza changed the base branch from dev to main June 9, 2022 07:55
@DaniSomoza DaniSomoza dismissed dasanra’s stale review June 9, 2022 07:55

The base branch was changed.

@DaniSomoza DaniSomoza changed the base branch from main to dev June 9, 2022 07:55
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2466847748

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 36.611%

Totals Coverage Status
Change from base Build 2466681972: 0.0%
Covered Lines: 3845
Relevant Lines: 9542

💛 - Coveralls

@DaniSomoza DaniSomoza merged commit 7e67c1f into dev Jun 9, 2022
@DaniSomoza DaniSomoza deleted the align-buttons-in-share-safe-app-page branch June 9, 2022 08:13
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align buttons in Share Safe app view
4 participants