-
Notifications
You must be signed in to change notification settings - Fork 364
fix: Crash if spending limit module is not deployed on a chain #3890
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
6e0ae9c
to
9a809e9
Compare
The safes load fine, so that part is fixed. I'm getting this error while loading a safe in bnb and gno chains. The safes load fine despite the error in the console. The error pops up in the console with every polling (every 15 secs) |
It seems that the |
This is very likely related to the issue we were experiencing yesterday before the hotfix. |
If the issues are unrelated we can pass this one to QA done. |
What it solves
Resolves #3889
How this PR fixes it
getAllowanceModuleDeployment
can't throw. It instead returnsundefined
if the module is not deployed on a network. Instead of manually throwing on our side, we handle theundefined
value.getSpendingLimitModuleAddress
can returnstring | undefined
instead of juststring
How to test it
arb1:0x2EBA2F2F1D599E9E2920ce4B70b1B881e76db82E
,aurora:0xDBe6f953a53eE0Eb7D28101e123D7bf6553638eb