This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
refactor: update SDK to use baseUrl
#3888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
Cool, thanks! The CGW debug toggle might benefit from a |
katspaugh
approved these changes
May 18, 2022
It already reloads. I'll merge this now as it is purely code-related. |
usame-algan
approved these changes
May 18, 2022
| @@ -18,15 +18,9 @@ describe('fetchTokenCurrenciesBalances', () => { | |||
| selectedCurrency: 'USD', | |||
| }) | |||
|
|
|||
| expect(getBalances).toHaveBeenCalledWith( | |||
| GATEWAY_URL, | |||
There was a problem hiding this comment.
It can also be removed from the imports of this file
| @@ -178,7 +178,7 @@ describe('<LoadSafePage>', () => { | |||
| await waitFor(() => { | |||
| fireEvent.change(safeAddressInputNode, { target: { value: validSafeAddress } }) | |||
|
|
|||
| expect(mockedEndpoints.getSafeInfo).toBeCalledWith(GATEWAY_URL, rinkebyNetworkId, validSafeAddress) | |||
There was a problem hiding this comment.
GATEWAY_URL can also be removed from the imports in this file
Pull Request Test Coverage Report for Build 2345706018
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Dependency update
How this PR fixes it
The gateway SDK has been updated to the latest version and all instances requiring the gateway URL to be passes removed. The environment-depebdent
baseUrlis now set on mount.How to test it
There should be no changes.