This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
feat: move batch execution out of experimental #3871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removes batch execution toggle from settings * adds onboarding widget around batch execution button
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
iamacook
reviewed
May 10, 2022
src/routes/safe/components/Transactions/TxList/BatchExecute.tsx
Outdated
Show resolved
Hide resolved
src/routes/safe/components/Transactions/TxList/BatchExecuteButton.tsx
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 2313147764
💛 - Coveralls |
iamacook
approved these changes
May 11, 2022
src/routes/safe/components/Transactions/TxList/BatchExecuteButton.tsx
Outdated
Show resolved
Hide resolved
| onMouseEnter={handleOnMouseEnter} | ||
| onMouseLeave={handleOnMouseLeave} | ||
| > | ||
| Execute Batch {isBatchable && `(${batchableTransactions.length})`} |
There was a problem hiding this comment.
Suggested change
| Execute Batch {isBatchable && `(${batchableTransactions.length})`} | |
| Execute Batch{isBatchable && ` (${batchableTransactions.length})`} |
iamacook
reviewed
May 11, 2022
src/routes/safe/components/Transactions/TxList/BatchExecuteButton.tsx
Outdated
Show resolved
Hide resolved
DiogoSoaress
suggested changes
May 11, 2022
src/routes/safe/components/Transactions/TxList/BatchExecuteButton.tsx
Outdated
Show resolved
Hide resolved
src/routes/safe/components/Transactions/TxList/BatchExecute.tsx
Outdated
Show resolved
Hide resolved
added 3 commits
May 11, 2022 15:25
* renames OnboardingWidget to OnboardingTooltip
|
A tiny comment: can we make the "Got it!" button w/o a background/border? Like a link. |
|
@katspaugh done. I changed the button variant to "text". |
|
Top job! All good from my side ;) |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #3857
How this PR fixes it
How to test it
Navigate to tx queue. Depending on how many signed txs the safe has the button will be enabled / disabled.
Initially the button will be promoted with a small tooltip until the user presses the "Got it" button
Analytics changes
Screenshots