Expand on a potential backwards compatibility issue, add myself to the author list #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mmv08
commented
Jul 5, 2024
mmv08
commented
- Highlight a potential backward compatibility issue
- Now having contributed something beyond grammar, I proudly add myself to the author list
nlordell
approved these changes
Jul 5, 2024
|
Might be worth mentioning that the deployer addresses can't deploy over the addresses anymore (so if the deployer private keys try to deploy a contract, it would revert; and that this is OK as those keys are used exclusively for deploying these |
nlordell
reviewed
Jul 7, 2024
| @@ -2,7 +2,7 @@ | |||
| rip: 77XX | |||
| title: Preinstall deterministic deployment factories | |||
| description: Proposal to add deployment factory contracts at common addresses to enable deterministic contract deployments | |||
| author: Richard Meissner (@rmeissner) | |||
| author: Richard Meissner (@rmeissner), Mikhail Mikheev (@mmv08), Nicholas Rodrigues Lordello (@nlordell) | |||
There was a problem hiding this comment.
You made a bunch of good suggestions and reviewed some ideas, I reckon that counts
nlordell
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.