Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: change the timeout duration from an int to a Timespan #18

Merged
merged 1 commit into from
Dec 16, 2024
Merged

FEAT: change the timeout duration from an int to a Timespan #18

merged 1 commit into from
Dec 16, 2024

Conversation

Jamesr51d
Copy link
Contributor

Change the timeout duration from an Int to a Timespan so that a more specific Timespan can be specified. Keep the default at 30 seconds.

@Jamesr51d
FEAT: change the timeout duration from an int to a Timespan so that a…
857833f 
… more specific Timespan can be specified. Keep the default at 30 seconds.
@Jamesr51d Jamesr51d requested review from jwrosewell and removed request for jwrosewell December 12, 2024 11:32
@Jamesr51d Jamesr51d marked this pull request as draft December 12, 2024 11:34
@Jamesr51d Jamesr51d linked an issue Dec 12, 2024 that may be closed by this pull request
Add a constructor that takes the task timeout as a timespan. Mark the current constructors as obsolete. #17
Closed
@Jamesr51d Jamesr51d marked this pull request as ready for review December 16, 2024 10:56
@github-actions GitHub Actions
Copy link

Unit Tests - Ubuntu_Any_CPU_Release

42 tests  ±0   42 ✅ ±0   12s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 857833f. ± Comparison against base commit 92e60a2.

@github-actions GitHub Actions
Copy link

Unit Tests - Ubuntu_Any_CPU_Debug

42 tests  ±0   42 ✅ ±0   13s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 857833f. ± Comparison against base commit 92e60a2.

@github-actions GitHub Actions
Copy link

Integration Tests - Ubuntu_Any_CPU_Release

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 857833f. ± Comparison against base commit 92e60a2.

@github-actions GitHub Actions
Copy link

Integration Tests - Ubuntu_Any_CPU_Debug

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 857833f. ± Comparison against base commit 92e60a2.

@github-actions GitHub Actions
Copy link

Unit Tests - Windows_Any_CPU_Release

42 tests  ±0   42 ✅ ±0   13s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 857833f. ± Comparison against base commit 92e60a2.

@github-actions GitHub Actions
Copy link

Integration Tests - Windows_Any_CPU_Release

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 857833f. ± Comparison against base commit 92e60a2.

@github-actions GitHub Actions
Copy link

Unit Tests - Windows_Any_CPU_Debug

42 tests  ±0   42 ✅ ±0   14s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 857833f. ± Comparison against base commit 92e60a2.

@github-actions GitHub Actions
Copy link

Integration Tests - Windows_Any_CPU_Debug

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 857833f. ± Comparison against base commit 92e60a2.

@Automation51D Automation51D merged commit 5ec2184 into main Dec 16, 2024
8 checks passed
@Automation51D Automation51D deleted the feature/timespan-timeout branch December 16, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justadreamer justadreamer justadreamer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a constructor that takes the task timeout as a timespan. Mark the current constructors as obsolete.
3 participants
@Jamesr51d @justadreamer @Automation51D